I made a Guitar Hero game mode

I hadn't really considered that. I'm currently cleaning up and fixing what code I have now for a pull request (probably tomorrow), so If I can't figure out how to make a loader for the .chart or .mid files, I'll write a Python script to convert it to an .ssc file and share that

Thank you for sharing the converter.
But actually that's tedious.
Stepmania should have the direct loader itself. it doesn't have to be converted by 3rd party apps. the Stepmania converts it to .scc.

But you can soon publish it right now on GitHub. if you'd finished cleaning the code, then you can declare your PR paper.
hmmm, but it's up to you.

Thank you for sharing the converter.
But actually that's tedious.
Stepmania should have the direct loader itself. it doesn't have to be converted by 3rd party apps. the Stepmania converts it to .scc.

I see what you're saying, and I agree. I'll hold off on making a pull request until I can get a working chart file loader. Pretty much every custom song for Guitar Hero is in a chart file, and it looks pretty straightforward to do.

OK, so after working on this some more, I fixed a lot of things:
* HOPOs now work in any mode, even edit/practice
* HOPOs also now work like they should, no more being able to hit notes by button mashing
* Fixed bugs with chords, now are hit correctly and are always playable

I also added a notesloader to load .chart files (used by the scorehero community to create custom songs for Guitar Hero 3)

Stuff that's still broken:
* Chords count as multiple notes
* No scoring system exclusively for Guitar mode yet
* The custom .chart loader isn't really a loader, it just creates an .ssc file to load from

Demo Video:


GitHub Source

Cool beans!

Also I wouldn't try and nuke the chord bug too fast. I noticed that in your first video, your max combo on the score screen was the same as your max combo in game despite said combo having chords in it, which seems to mean that notes are actually being counted separately, not just faking it like the "CountNotesSeparately" thing does currently. Kyzentun's been trying to make an option that allows you to turn chord cohesion off for keyboard play (and have it off by default for certain modes that are meant to be played with keys/buttons), so this could be key to achieving this in SM5.

Yeah, the chord bug is low on my priority list. Especially since I realized I was working off the 5.0.X branch this whole time instead of 5_1_0. So, I'm going to be doing my changes to that and seeing if I can get the notesloader actually working, then maybe a new scoring system if I'm not sick of this by then.

Okay, question: do you think "guitar-3x2" (aka. Guitar Hero Live) would be possible?

It would be a bit trickier to implement given that we'd have to code six notes into three on-screen lanes and have the noteskin handle the "vertical chords" correctly.

Okay, question: do you think "guitar-3x2" (aka. Guitar Hero Live) would be possible?

Sure, it would just be another style added onto the guitar game mode, likely another noteskin would be needed to make it playable. As for numbering the frets, I think it would be easiest to do the white frets as Fret1 through Fret3 (I believe that's the row used for easy mode, correct me if I'm wrong), then the black frets would be Fret4 through Fret6. The hardest part would be getting the vertical chords to display in the noteskin, as it stands I'm getting annoyed by how notes are chopped in half when they overlap (you can see this during the solo in the video, it also makes some metalcore songs unplayable because all notes are invisible). I'm not sure if that's a bug with how I'm building it now, but I'll be trying to fix that as I move my changes to 5_1_0 this week.

In the meantime if anyone reading this knows how to force noteskins to show the entire note, even if it's being overlapped, or if it's just a problem with debug/osx/5.0.X, please let me know

That's almost certainly a mistake in the noteskin you made. It'll probably go away as part of moving your changes to 5_1_0.