[Patch] Prevent focus lost at Fullscreen on X11

[howl]

Originally Posted by AJ 187

On Windows, I click outside of the window and then back inside of it, that gets it working again (most of the time, anyways). I am not sure if it works on Linux, but I figure it's worth a shot. I usually find it happening after changing the resolution.

Well, find it, StepMania when in FullScreen takes the focus of the keyboard so there is not way to use alt+tab and similar. The problem is that the focus is be lost when there is a big screen resolution chage, so, I have make this patch not to grab only when enter in FullScreen and to grab the keyboard also when there is a resolution chage at fullscreen. Tested and solves the issue.

This is an important issue because people that doesn't know anything about ttys will be left with a locked interface.

Index: src/arch/arch/LowLevelWindow/LowLevelWindow_X11.cpp
===================================================================
--- src/arch/LowLevelWindow/LowLevelWindow_X11.cpp (revision 28234)
+++ src/arch/LowLevelWindow/LowLevelWindow_X11.cpp (working copy)
@@ -181,11 +181,16 @@
 		// context.
 		bNewDeviceOut = false;
 	}
-	
-	g_iOldSize = XRRConfigCurrentConfiguration( g_pScreenConfig, &g_OldRotation );
-	
+
 	if( !p.windowed )
 	{
+		if( m_bWasWindowed )
+		{
+			// If the user changed the resolution while StepMania was windowed we overwrite the resolution to restore with it at exit.
+			g_iOldSize = XRRConfigCurrentConfiguration( g_pScreenConfig, &g_OldRotation );
+			m_bWasWindowed = false;
+		}
+
 		// Find a matching mode.
 		int iSizesXct;
 		XRRScreenSize *pSizesX = XRRSizes( Dpy, DefaultScreen(Dpy), &iSizesXct );
@@ -210,13 +215,10 @@
 		XMoveWindow( Dpy, Win, 0, 0 );
 		
 		XRaiseWindow( Dpy, Win );
-		
-		if( m_bWasWindowed )
-		{
-			// We want to prevent the WM from catching anything that comes from the keyboard.
-			XGrabKeyboard( Dpy, Win, True, GrabModeAsync, GrabModeAsync, CurrentTime );
-			m_bWasWindowed = false;
-		}
+
+		// We want to prevent the WM from catching anything that comes from the keyboard.
+		// We should do this every time on fullscreen and not only we entering from windowed mode because we could lost focus at resolution change and that will leave the user input locked.
+		XGrabKeyboard( Dpy, Win, True, GrabModeAsync, GrabModeAsync, CurrentTime );
 	}
 	else
 	{

[howl]

I have added to the patch the ability to solve StepMania leaving it's last used screen resolution at full-screen on exit or window mode change, now restores the resolution that user had when starting StepMania.

[howl]

Updated one more time, this is a uncommon situation but if the user changed his resolution while in window mode the resolution to restore should be updated, so now the patch makes StepMania to also save the resolution when entering from windowed mode to fullscreen mode.

[howl]

Another update, analyzing the last patch was possible to remove the save of resolution in the constructor by moving if( m_bWasWindowed ) before changing the screen resolution.

[DaVince]

I know of another fullscreen issue where the mouse pointer stays visible. Not sure if this patch somehow fixes it too but a mouse pointer in the middle of the screen while playing can definitely be distracting.

[howl]

Originally Posted by DaVince

I know of another fullscreen issue where the mouse pointer stays visible. Not sure if this patch somehow fixes it too but a mouse pointer in the middle of the screen while playing can definitely be distracting.

That happens you always, or only sometimes? I saw that only one time but is an issue more related to X11 or the window manager itself.

[DaVince]

Only sometimes, surprisingly. Could be a video driver bug, but I dunno (Intel video drivers have improved in Linux lately, especially for my 915GM). It happens in both Xfce and LXDE, with or without compositing enabled.

I do know that StepMania locks the mouse pointer in place in fullscreen mode since I can't move it away once it's on the screen. Some other apps that showed similar behaviour would make the cursor invisible once it even moved a pixel, so if mouse movement was actually possible in fullscreen I could probably "remove the annoyance".

[pcvii]

Yea, I've had the same problem with the mouse pointer. I thought it was strange. Most of my issues are when changing settings. Sometimes step mania just crashes sometimes this bug you just fixed happens. I look forward to seeing your patches, keep up the good work.

[howl]

If I have time I will try to make StepMania window unable to be Maximized or Resized.