Can't find the cause of compilation error with this patch

[howl]

http://pastie.org/686104

It's essentially Ondřej Hošek's patch with Damien Thébault's make and configure. The error output compiling it in top of 28221 revision (the lastest ones I didn't get to compile without the patch applied) is:

http://pastie.org/686110

I can't get the issue because all the unreferenced functions all in the <pulse/simple.h> include.

By now the only working way is Damien Thébault's, work perfect, no artifacts or anything else like alsa, but, when closing stepmania a crash is done. The problem of Damien Thébault's patch is that it doesn't follow the structure of the stepmania audio drivers, but uses the advanced asynchronous API of pulseaudio. Ondřej Hošek's one is complaint the driver structure but uses the synchronous simple API of pulseaudio, but indeed it should be enough for stepmania needs.

If someone can see where is the issue for the functions be unreferenced I could compile and test myself, no need to lose your time testing.

Thanks in advice.

[pcvii]

is it possible to run stepmania in a debug mode or do we need to use makefiles and compile and test? :P

I would like to do what you did that got rid of the artifiacts. I mean if you could run stepmania in a debug mode then when it exits you could see what is causing the crash and possibly stop it.

I come from windows with Visual C++ Express 2008 :P I'm not sure what the best tools are for linux. I just follow directions and do the configure and make thing with the scripts.

I hope you can get this to work. One less reason to run back to windows

edit: I think I found one of the patches you were talking about. Doing a google search. http://old.nabble.com/StepMania-Puls...d24506132.html. I'm guessing since it's fairly recent it's one of them. I think I'll try to apply it later. Not sure how to yet.

edit: http://sourceforge.net/mailarchive/f...stepmania-devs I was wondering where you download it. I guess I was looking at some kinda copy of the archieve. The actual archieve has the link for downloading the file. Thought if anyone else reads this they might want to know.

[howl]

Yes that is the Damien's patch, it patch with no problems lastest stepmania's revisions, but I use the 28221 revision because the newest fail to compile they selfs without any patch.

If you want to try it first make sure you have all installed all the dependencies of StepMania:

sudo apt-get install libasound2-dev libmad0-dev libtheora-dev libvorbis-dev libpng-dev libjpeg-dev libglu1-mesa-dev libgl1-mesa-dev libgtk2.0-dev xorg-dev libxrandr-dev automake1.10 build-essential subversion curl g++

Or the method of your prefered distribution.

Also install pulse-dev:

sudo apt-get install libpulse-dev

Then make a directory where download stepmania svn and save there the patch with the name_you_want.patch, from a terminal go to the directory and inside it:

svn co https://svn.stepmania.com/svn/trunk/stepmania -r 28221

When it has finish:

cd stepmania
patch -p0 -i ../name_you_want.patch

The output should be some files patched and one with fuzz 1. Now you have the source patched. So:

./autogen.sh
./Utils/build.sh

Then stepmania should compile without problems, if something fails execute:

./Utils/build.sh --verbose

to see what is failing.

to start StepMania:

./stepmania

You should notice that the sound is perfect and if you put StepMania and launch a volume manager that uses PulseAudio you should see the "Stepmania" stream, this should be changed to "StepMania" but it's a very very minor to do so xD.

When you exits the game it should report the crash.

[howl]

I forget, use the last Damien's patch version 0.2.

[pcvii]

Thanks for the instructions. I got the patch gonna try to apply it now.
--EDIT--
It's working perfectly. And for some reason it isn't crashing on exit atleast it hasn't yet. Exited twice. I followed you're instructions line by line.

One issue I had was when I applied a change in settings my keyboard and mouse became un responsive. While the game was still going on the screen. I don't know if that's related or not. I got the settings how I want them so I don't plan on changing anything for a bit.

[howl]

Originally Posted by pcvii

Thanks for the instructions. I got the patch gonna try to
It's working perfectly. And for some reason it isn't crashing on exit atleast it hasn't yet. Exited twice. I followed you're instructions line by line.

Wow, ¿really?, what version of PulseAudio you have? mine is 0.9.19. The only way to notice the crash is in the output of the console because is just when closing :)

Originally Posted by pcvii

One issue I had was when I applied a change in settings my keyboard and mouse became un responsive. While the game was still going on the screen. I don't know if that's related or not. I got the settings how I want them so I don't plan on changing anything for a bit.

This issue is related to the focus of the window, I haven't found the way to refocus stepmania.

[AJ 187]

Originally Posted by howl

This issue is related to the focus of the window, I haven't found the way to refocus stepmania.

On Windows, I click outside of the window and then back inside of it, that gets it working again (most of the time, anyways). I am not sure if it works on Linux, but I figure it's worth a shot. I usually find it happening after changing the resolution.

[howl]

Originally Posted by AJ 187

On Windows, I click outside of the window and then back inside of it, that gets it working again (most of the time, anyways). I am not sure if it works on Linux, but I figure it's worth a shot. I usually find it happening after changing the resolution.

Yes, when changing resolution, at least, from one very small to one very high, the rest of options doesn't lost the focus. The problem is when stepmania is in fullscreen mode, there is no way to recover the focus because alt+tab doesn't work with sm in full.

[howl]

Well, I found it, don't know why I did't notice before. The crash happens when closing but during the game sound is ok, so the problem is something that should be done in the destructor of the driver, so, I added the pertinent funtions to close and free pulseaudio's needed varaibles and voila, the Damien's patch now works well.

Also solved another thing I notice. After using stepmania with pulse driver then is impossible to use the alsa-sw driver because hardware busy, but if you didn't uses before the pulse plugin it works, now there is no problem.

Exiting using pulse driver says:
Mixing 0.000000 ahead in 0 Mix() calls
Mixing underruns: 1

With alsa-sw:
Mixing 469.737000 ahead in 15148 Mix() calls
Mixing underruns: 8

Is normal that with pulse driver Mix has 0 calls?

The working pulse driver patch is this:
http://pastie.org/687933

I added the following lines:

	pa_context_disconnect(m_PulseCtx);
	pa_context_unref(m_PulseCtx);
	pa_threaded_mainloop_stop(m_PulseMainLoop);
	pa_threaded_mainloop_free(m_PulseMainLoop);

[howl]

I have been using it and seems to be stable. Could be possible to add it mainstream in StepMania SVN? The only thing I see is that doesn't follow the desing of the rest RageSoundDrivers and doesn't have methods like GetPlayLatency.

If I can I will try to adapt it with a PulseHelper to take out Pulse's specific code and make use of RageThreads, but, It will be the same but written in another way.

This driver can solve some problems that linux users report like sound stuttering, stepmania not in the default selected audio device, sound underruns...